[pptp-server] Patch for pptpd-1.0.0

[David Luyer]

Also looked into the out of order packet problem.

I think you can see what's happening here... look at the client IPs and times!

Aug 29 21:20:44 kryten pptpd[1848]: CTRL: Client 203.143.254.228 control connection started
Aug 29 21:20:44 kryten pptpd[1848]: CTRL: Starting call (launching pppd, opening GRE)
Aug 29 21:20:44 kryten pptpd[1848]: GRE: Discarding duplicate packet
Aug 29 21:35:07 kryten pptpd[1848]: GRE: Discarding out of order packet (expected: 2896 received: 0)
Aug 29 21:35:07 kryten pptpd[1848]: GRE: Discarding out of order packet (expected: 2896 received: 1)
Aug 29 21:35:10 kryten pptpd[1848]: GRE: Discarding out of order packet (expected: 2896 received: 2)
Aug 29 21:35:10 kryten pptpd[1848]: GRE: Discarding out of order packet (expected: 2896 received: 3)
[...]
Aug 29 21:44:26 kryten pptpd[1848]: GRE: Discarding out of order packet (expected: 2896 received: 2891)
Aug 29 21:44:26 kryten pptpd[1848]: GRE: Discarding out of order packet (expected: 2896 received: 2892)
Aug 29 21:44:26 kryten pptpd[1848]: GRE: Discarding out of order packet (expected: 2896 received: 2893)
Aug 29 21:44:26 kryten pptpd[1848]: GRE: Discarding out of order packet (expected: 2896 received: 2894)
Aug 29 21:44:26 kryten pptpd[1848]: GRE: Discarding out of order packet (expected: 2896 received: 2895)
Aug 29 21:44:26 kryten pptpd[1848]: GRE: Discarding duplicate packet

Aug 29 21:35:07 kryten pptpd[1908]: CTRL: Client 203.143.254.228 control connection started
Aug 29 21:35:07 kryten pptpd[1908]: CTRL: Starting call (launching pppd, opening GRE)
Aug 29 21:35:07 kryten pptpd[1908]: GRE: Discarding duplicate packet
Aug 29 22:06:42 kryten pptpd[1908]: GRE: Discarding out of order packet (expected: 4740 received: 0)
Aug 29 22:06:43 kryten pptpd[1908]: GRE: Discarding out of order packet (expected: 4740 received: 1)

Aug 29 22:06:42 kryten pptpd[2064]: CTRL: Client 203.143.254.228 control connection started
Aug 29 22:06:42 kryten pptpd[2064]: CTRL: Starting call (launching pppd, opening GRE)
Aug 29 22:06:42 kryten pptpd[2064]: GRE: Discarding duplicate packet

Client brings up new connection, old connection sees packets from new
connection, old connection sits around listening to packets for some
time.

The thing is, we've just switched one network portion over to pptpd and we've 
had 5 clients do this within the first day (as well as a couple of dozen 
processes doing the infinite loop I've sent a patch off to Matt for).

So I'll see what I can do about this one too.

Never saw either problem to any significant degree at UWA - and we had around 
64 simultaneous ethernet-connected PPTP clients there, we're running around the
same number here (on the first day though - it may increase; the connection is
via 2Mbps AiroNet bridges to Ethernet wired building but essentially similar),
but seeing a whole new set of problems straight off.

David.
-- 
----------------------------------------------
David Luyer
Senior Network Engineer
Pacific Internet (Aust) Pty Ltd
Phone:  +61 3 9674 7525
Fax:    +61 3 9699 8693
Mobile: +61 4 1064 2258, +61 4 1114 2258
http://www.pacific.net.au        NASDAQ: PCNTF
<< fast 'n easy >>
----------------------------------------------