[pptp-server] Follow-up to problem compiling ppp.c

[Giulio Orsero]

On Mon, 12 Feb 2001 11:27:36 -0600, you wrote:

>The showstopper is:
>ppp.c: In function: 'rcv_proto_unknown': ppp.c:2563: too few arguments to
>function 'kill_fasync_R8e941aa8'
>The compile then exits with error 2.
>I've found that editing the line of code for kill_fasync and adding ", 
>POLL_IN" (no quotes of course) before the closing ) allows the module to 

I use redhat kernels as a base. I've been using 2.2.16-22 for some time
now, and today I compiled mppe  with the new 2.2.17-14. 
ppp_mppe loads succesfully in 2.2.17 but couldn't try pptpd yet.

I get the 2 warnings
ppp.c:188: warning: static declaration for 
'ppp_register_compression_R9682e733' follows non-static
ppp.c:189: warning: static declaration for 
'ppp_unregister_compression_Ra1b9928df' follows non-static

both in 2.2.16 and 2.2.17 and I just ignore them.

drivers/net/ppp.c is the same in redhat2.2.16+mppe and redhat2.2.17+mppe

This is the diff between the original linux/ppp.c of ppp-2.3.11 and the
ppp.c in drivers/net (word wrap will break it):
===========
--- ppp-2.3.11/linux/ppp.c      Thu Dec 23 02:48:45 1999
+++ rhat70a/BUILD/linux/drivers/net/ppp.c       Tue Feb 13 23:21:15 2001
@@ -77,6 +77,9 @@
 #include <linux/signal.h>      /* used in new tty drivers */
 #include <asm/system.h>
 #include <asm/bitops.h>
+#if LINUX_VERSION_CODE < VERSION(2,2,0)
+#include <asm/segment.h>
+#endif
 #include <linux/if.h>
 #include <linux/if_ether.h>
 #include <linux/netdevice.h>
@@ -2351,6 +2354,7 @@
                                if (new_count == DECOMP_FATALERROR) {
                                        ppp->flags |= SC_DC_FERROR;
                                } else {
+                                   if
(ppp->sc_rcomp->compress_proto!=CI_MPPE)
                                        ppp->flags |= SC_DC_ERROR;
                                }
                        }
@@ -2556,7 +2560,7 @@
 
        wake_up_interruptible (&ppp->read_wait);
        if (ppp->tty->fasync != NULL)
-               kill_fasync (ppp->tty->fasync, SIGIO);
+               kill_fasync (ppp->tty->fasync, SIGIO, POLL_IN);
 
        return 1;
 }
=============

POLL_IN is added by hand, the remaining is due to
ppp-2.3.11-openssl-0.9.5-mppe.patch that gets applied to ppp.c before it
is installed in the kernel tree.

$ uname -r
2.2.17-14.g1
$ lsmod|grep ppp
ppp_mppe               13584   0  (unused)
ppp                    20012   0  [ppp_mppe]
slhc                    4328   0  [ppp]
$

-- 
giulioo at pobox.com