[pptp-server] CTRL: couldn't read packet header (exit)

Patrick J. LoPresti patl at curl.com
Mon Jan 31 15:01:28 CST 2000


This is a very simple bug which I fixed in PoPToP 1.1.1.  Grab that or
apply the following patch.  (Note: Line numbers and/or whitespace may
be messed up due to other changes I made in pptpctrl.c.  The context
should be enough, however.)

 - Pat

Index: pptpctrl.c
===================================================================
RCS file: /projects/systems/cvs-root/pptpd/pptpctrl.c,v
retrieving revision 1.3
retrieving revision 1.4
diff -u -r1.3 -r1.4
--- pptpctrl.c	1999/12/23 21:43:33	1.3
+++ pptpctrl.c	1999/12/29 16:06:41	1.4
@@ -482,9 +482,17 @@
 		tv.tv_usec = 0;
 
 		/* Wait for STOP CTRL CONN RQST or RPLY */
-		while (select(clientSocket + 1, &connSet, NULL, NULL, &tv) == 1) {
-			switch((pkt = read_pptp_packet(clientSocket, packet, rply_packet, &rply_size))) {
-			case STOP_CTRL_CONN_RQST:
+		while (select(clientSocket + 1, &connSet, NULL, NULL,
+                              &tv) == 1) {
+                  pkt = read_pptp_packet(clientSocket, packet,
+                                         rply_packet, &rply_size);
+                  if (pkt == 0) {
+                    syslog (LOG_WARNING,
+                            "EOF reading control message");
+                    break;
+                  }
+                  else switch (pkt) {
+                        case STOP_CTRL_CONN_RQST:
 				send_pptp_packet(clientSocket, rply_packet, rply_size);
 				goto skip;
 			case CALL_CLR_RQST:




More information about the pptp-server mailing list