[pptp-server] Speed/performance problems with v0.9.10 and 98

[Philip Van Baren]

I found what caused my performance decrease:
  in 0.9.5 the PCKT_RECV_WINDOW_SIZE was changed to 1 (was 2 in 0.9.4)

Bumping that value back up to 2 in the source for version 0.9.10 fixes my
performance problem.

Phil VanBaren


> That's interesting.  Can you positively verify a decrease in performance
> between 0.9.4 and 0.9.5?  0.9.5 fixes some important bugs.
>
> If there is definitely a performance decrease there, try backing out the
> changes one by one and find which one caused it.
>
> The first two to try backing out would be the specific GRE bind() and the
> sequence number checking change.
>
> Is your pptpd logging anything on the server, eg, heaps of out-of-order
> packets?
>
> David.
>


--- pptpd-0.9.10/pptpdefs.h     Mon Aug  2 19:25:10 1999
+++ pptpd-0.9.10-new/pptpdefs.h Fri Aug  6 21:13:25 1999
@@ -90,7 +90,7 @@
 #define MAX_CHANNELS                   0x0001

 /* Out Call Reply Defines */
-#define PCKT_RECV_WINDOW_SIZE          0x0001
+#define PCKT_RECV_WINDOW_SIZE          0x0002
 #define PCKT_PROCESS_DELAY             0x0000
 #define CHANNEL_ID                     0x00000000